Guard np.row_stack overload for numpy < 2.5 (#907) - #916
Open
CodersAcademy006 wants to merge 1 commit into
Open
Conversation
numpy 2.5 removes np.row_stack, so overloading it unconditionally for numpy >= 2.0 fails on numpy 2.5. Bound the overload to [2.0, 2.5) to match upstream numba (numba/numba#10645). Closes NVIDIA#907 Signed-off-by: Srijan Upadhyay <srjnupadhyay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy2.5 removesnp.row_stack. The overload was registered unconditionally fornumpy_version >= (2, 0), so it breaks under numpy 2.5. This bounds it to[2.0, 2.5), mirroring the upstream numba fix in numba/numba#10645 (as suggested by the reporter).Change
numba_cuda/numba/cuda/np/arrayobj.py:Closes #907
cc @gmarkall