Migrates resolution cache code from numba fixing a JIT speed regression. - #915
Open
c200chromebook wants to merge 1 commit into
Open
Migrates resolution cache code from numba fixing a JIT speed regression.#915c200chromebook wants to merge 1 commit into
c200chromebook wants to merge 1 commit into
Conversation
Also corrects a trivial bug normalize_dict(obj) should be working on obj not kws.
Author
|
@gmarkall would you mind having a look at this one? it is kind of annoying for us |
Contributor
|
@c200chromebook Thanks for the PR and the ping. I'm no longer working on Numba-CUDA, so I will defer to @kkraus14 on where to go with this PR. |
Contributor
|
@c200chromebook please see https://github.com/NVIDIA/numba-cuda#maintenance-notice We are only accepting security issues and critical bug fixes at this time for numba-cuda. I would recommend trying to move to numba-cuda-mlir and if the same JIT speed regression exists there we will happily try to resolve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a straight-shot move of resolution cache from the original numba to correct a compile time regression. We have it monkeypatched in now and it works ok. Anyone using the sol'n would probably benefit from it. We are working to get MLIR up and running for use case as well (note recent bug report).