Add missing vendor-in changes to numba-cuda - #887
Open
acosmicflamingo wants to merge 2 commits into
Open
Conversation
Changes from the following commit (from upstream numba) didn't make it through to numba-cuda: https://github.com/numba/ numba/commit/3bac3bf9d7479107a3819b480abee8e57f59ea96 Re-adding the work Todd A. Anderson had made, where he had commented "Extend lazy_pformat to work on arbitary string producing functions for use in other places where we need lazy but it doesn't use pformat."
acosmicflamingo
changed the title
atmnp
approved these changes
Jul 13, 2026
atmnp
left a comment
atmnp
left a comment
Contributor
There was a problem hiding this comment.
I had a similar change like this locally at some point, ran into the same bug it seemed to be transient before I got around to submitting the fix. Thanks for taking the time!
Contributor
|
/ok to test |
@atmnp, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Author
|
@atmnp woohoo! Thanks for taking the time to review and merge! I imagine you are already aware but I also have a PR that fixes it in numba-cuda-mlir, just so you know :) |
Author
|
@atmnp oh no, the dreaded |
Author
|
Could anyone with admin privileges please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from the following commit (from upstream numba) didn't make it through to numba-cuda: numba/numba@3bac3bf
Re-adding the work Todd A. Anderson had made, where he had commented "Extend lazy_pformat to work on arbitary string producing functions for use in other places where we need lazy but it doesn't use pformat."
Want to mention that I deliberately didn't add a test to this PR because I felt like this fell under the category of tests that upstream numba is responsible for. I'd be happy to add a test; wanted to avoid giving the impression that I don't think about adding tests until a maintainer asks me to ;)