Skip to content

allow specific precompiled images to be rebuilt#636

Open
rahulait wants to merge 1 commit into
NVIDIA:mainfrom
rahulait:rebuild-precompiled-image
Open

allow specific precompiled images to be rebuilt#636
rahulait wants to merge 1 commit into
NVIDIA:mainfrom
rahulait:rebuild-precompiled-image

Conversation

@rahulait

@rahulait rahulait commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

This PR adds the following capability:

Manual workflow inputs for targeted builds — each matrix dimension (driver branch, kernel flavor, dist, LTS kernel) can be filtered to a single value via workflow_dispatch inputs, instead of always building the full matrix.

Force rebuild flag — a new force_rebuild input that bypasses the ghcr.io tag-existence check (nvcr.io is still treated as authoritative). This will enable us to build and push updated images to ghcr.io which then can be published to nvcr.io

@shivakunv

Copy link
Copy Markdown
Contributor

To override image in staging , we need to change:

precompiled.sh :- 

function imageExists(){
	regctl manifest get $1 --list > /dev/null && return 0 || return 1
} 

We should add an md5sum check between the staging and ghcr repo to verify whether the image is same or not .

@rahulait rahulait force-pushed the rebuild-precompiled-image branch from dc1ee9b to 65f583c Compare March 6, 2026 05:30
@rahulait

rahulait commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

To override image in staging , we need to change:

precompiled.sh :- 

function imageExists(){
	regctl manifest get $1 --list > /dev/null && return 0 || return 1
} 

We should add an md5sum check between the staging and ghcr repo to verify whether the image is same or not .

Fixed this in change https://github.com/NVIDIA/gpu-driver-container/compare/dc1ee9b75cb65c00cb3a4c8a9bf15779e11e53e4..65f583ce429aa61f709a5194346e18009afda582

Comment thread .github/workflows/precompiled.yaml
Comment thread tests/scripts/findkernelversion.sh

@shivakunv shivakunv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulait rahulait self-assigned this Mar 31, 2026
@rahulait rahulait force-pushed the rebuild-precompiled-image branch from 65f583c to 0b714a8 Compare April 24, 2026 14:31
@copy-pr-bot

copy-pr-bot Bot commented Apr 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rahulait

Copy link
Copy Markdown
Contributor Author

/ok to test 0b714a8

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
@rahulait rahulait force-pushed the rebuild-precompiled-image branch from 0b714a8 to bb0cc4d Compare June 3, 2026 03:41
@rahulait

rahulait commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test bb0cc4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants