Return no attempts when a probe's prompt set is empty - #2035
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
Probe.probe() used len(prompts) for the preparation progress bar but then indexed prompts[0] to detect string prompts. An empty prompt set (for example one emptied by translation under some langproviders) reached the subscript and raised IndexError deep in the run instead of producing zero attempts. Return an empty attempt list (with a warning) when the prompt set is empty, before the prompts[0] check. Adds a regression test. Signed-off-by: eeshsaxena <eeshsaxena@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2026
Problem
Probe.probe()ingarak/probes/base.pyuseslen(prompts)for the preparation progress bar and then indexesprompts[0]to decide whether prompts are plain strings:An empty prompt set (including one emptied by translation under some langproviders) reaches the subscript and raises
IndexError: list index out of rangedeep in the run, rather than simply producing zero attempts. This is observed onmainviatests/probes/test_probes.py::test_probe_prompt_translation[...SystemPromptExtraction].Fix
Return an empty attempt list (with a warning naming the probe) when the prompt set is empty, before the
prompts[0]check.Test
Added
test_probe_empty_prompt_set_returns_no_attempts, which loadsprobes.test.Test, empties its prompts, and assertsprobe()returns no attempts. It fails withIndexErrorbefore this change and passes after.