fix: stop FileDetector format mismatch from aborting the run - #2029
Open
patriciapampanelli wants to merge 1 commit into
Open
fix: stop FileDetector format mismatch from aborting the run#2029patriciapampanelli wants to merge 1 commit into
patriciapampanelli wants to merge 1 commit into
Conversation
…borting the run Signed-off-by: Patricia Pampanelli <ppampanelli@nvidia.com>
jmartin-tech
approved these changes
Aug 7, 2026
jmartin-tech
left a comment
Collaborator
There was a problem hiding this comment.
This make sense to me as a behavior change since the introduction of support for None responses from detectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while reviewing #1952, which adds an
S008exec→fileformats.FileIsExecutableintent mapping. With it applied,--spec probes.grandma.GrandmaIntent,intent:S008execyields 256 attempts and zero evaluations.FileDetector.detect()raisesValueErrorwhenattempt.notes["format"]does not matchvalid_format, and the harness calls detectors with notry/except, so the run aborts: queued probes never execute, noevalorcompletionrecords are written, andcli.mainexits 0. The mapping only exposes this.The raise becomes a warning and one
Noneper output, not0.0, since the outputs are not filenames at all. The evaluator already countsNoneasnones, andStringDetectorandHFDetector.graceful_failuse the same idiom.Reproduction
Before:
probes.test.Testnever runs; the report holds 1 attempt, 0eval, 0completion.After: both probes run, 9 attempts, 2
eval, 1completion.Both exit 0 — the exit code never signalled the abort.