Skip to content

fix: default config_root to _config in InjectAtbash #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmartin-tech merged 1 commit into from
Aug 4, 2026
+15 −1
Merged

fix: default config_root to _config in InjectAtbash #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion garak/probes/encoding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ def atbash(text: bytes) -> bytes:

encoding_funcs = [atbash]

def __init__(self, config_root=None):
def __init__(self, config_root=_config):
garak.probes.Probe.__init__(self, config_root=config_root)
EncodingMixin.__init__(self)

Expand Down
14 changes: 14 additions & 0 deletions tests/plugins/test_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
# SPDX-License-Identifier: Apache-2.0

import importlib
import inspect
import pytest

import garak._plugins
from garak import _config

PLUGINS = []
for plugin_type in garak._plugins.PLUGIN_TYPES:
Expand All @@ -24,3 +26,15 @@ def test_plugin_structure(classname):
assert hasattr(c, "extra_dependency_names") and isinstance(
c.extra_dependency_names, list
), "extra_dependency_names must be a list"


@pytest.mark.parametrize("classname", PLUGINS)
def test_plugin_config_root_default(classname):
m = importlib.import_module("garak." + ".".join(classname.split(".")[:-1]))
c = getattr(m, classname.split(".")[-1])

param = inspect.signature(c.__init__).parameters.get("config_root")
assert param is not None, "plugin __init__ must accept config_root"
assert (
param.default is _config
), "config_root must default to garak._config so direct instantiation honours global config"
Loading