Fix incorrect distances tensor type in cuvsCagraSearch - #2372
Open
imotov wants to merge 2 commits into
Open
Conversation
imotov
added
bug
Per the cuvsCagraSearch contract [1], `distances` is always float32 regardless of the query type. Force the distances buffer and tensor to float32 (matching the neighbors path) and add a byte-query search regression test. [1] https://github.com/NVIDIA/cuvs/blob/6858b2988b9ebfcfaadb72a715e1963349d265b7/c/include/cuvs/neighbors/cagra.h#L672
imotov
force-pushed
the
fix-invalid-distances-tensor-type
branch
from
July 28, 2026 23:08
752ade7 to
dbb5ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the cuvsCagraSearch documentation [1],
distancesis always float32 regardless of the query type. Force the distances buffer and tensor to float32 and add a byte-query search regression test.[1]
cuvs/c/include/cuvs/neighbors/cagra.h
Line 693 in 6858b29