Fix cuvs-bench opensearch recall and save results - #2369
Draft
jrbourbeau wants to merge 3 commits into
Draft
Conversation
Signed-off-by: James Bourbeau <jbourbeau@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…ch-fixup Signed-off-by: James Bourbeau <jbourbeau@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes updates to close #2358 and also address the opensearch backend not saving persistent results.
Primary changes are:
searchmethods now return a list of results that are passed to the orchestrator where recall can be computed for each result separately (xref [BUG] ef_search search parameter failed to sweep correctly #2358 (comment))--data-exportflag is deprecated since this always happens now.cc @jnke2016
Closes #2358