Fix crash when symmetry generators are pruned

[nguidotti]

If the symmetry generators are pruned from one restart to the next, surviving_generators_ will store the incorrect set of indexes and cause a out-of-bound memory access.

Checklist

• I am familiar with the Contributing Guidelines.
• Testing
  • New or existing tests cover these changes
  • Added tests
  • Created an issue to follow-up
  • NA
• Documentation
  • The documentation is up to date with these changes
  • Added new documentation
  • NA

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7865d0f0-1c29-411e-a1be-74afa9715ee4

📥 Commits

Reviewing files that changed from the base of the PR and between 361d41f and 5e2ad9c.

📒 Files selected for processing (1)

• cpp/src/branch_and_bound/symmetry.hpp

---

📝 Walkthrough

Walkthrough

orbital_fixing_t::reset now sizes surviving_generators_ using the symmetry object’s current generator count before repopulating active generator indices.

Changes

Symmetry generator reset

Layer / File(s)	Summary
Reset generator storage cpp/src/branch_and_bound/symmetry.hpp	reset resizes surviving_generators_ to the current num_generators value and reinitializes the active generator indices.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: chris-maes, hlinsen, ramakrishnap-nv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description clearly explains the crash caused by stale generator indexes after symmetry generators are pruned.
Title check	✅ Passed	The title clearly identifies the primary change: fixing a crash caused by pruned symmetry generators.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

CI Test Summary

✅ All 31 test job(s) passed.

[nguidotti]

/merge