Use configured feasibility tolerance in Papilo - #1688
Open
hlinsen wants to merge 3 commits into
Open
Conversation
Signed-off-by: Hugo Linsenmaier <hlinsenmaier@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR updates the default MIP absolute and relative tolerances. Papilo presolve now uses the caller-provided absolute tolerance for feasibility checks. ChangesMIP tolerance updates
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Kh4ster
approved these changes
Aug 7, 2026
Contributor
Author
|
/ok to test c6ef256 |
CI Test Summary⏭️ All 5 test job(s) skipped. |
Contributor
Author
|
/ok to test 1e5f376 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I compared main against fix-papilo-feastol using two complete runs of all 240 MIPLIB instances. Each main/branch instance pair ran sequentially on the same H100, using the same physical node, GPU index, 28-thread CPU mask, and 600-second time limit.
Overall performance is similar. The branch finds ~3.5 more solutions within 0.1% of the best-known objective and reduces solutions failing our postsolve feasibility check
The solution is not feasible after post solvefrom ~2.5 to ~2.0 per run.The +0.411 average objective gap difference is driven almost entirely by one instance,
gfd-schedulen180f7d50m30k18.Main solves this instance consistently, while the branch sometimes solves it optimally and sometimes finds no incumbent.
I couldn't reproduce #1502 and LP should simply use PSLP presolve.