Skip to content

Use configured feasibility tolerance in Papilo - #1688

Open
hlinsen wants to merge 3 commits into
NVIDIA:mainfrom
hlinsen:fix-papilo-feastol
Open

Use configured feasibility tolerance in Papilo#1688
hlinsen wants to merge 3 commits into
NVIDIA:mainfrom
hlinsen:fix-papilo-feastol

Conversation

@hlinsen

@hlinsen hlinsen commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
Metric Main fix-papilo-feastol Branch − main
Feasible 226.5 225.0 −1.5
Optimal 73.5 71.5 −2.0
Average objective gap 8.091% 8.502% +0.411 points
MIP gap, shifted geomean 5.949% 6.051% +0.102 points
<0.1% objective gap 132.0 135.5 +3.5
Solutions failing cuOpt’s postsolve feasibility check 2.5 2.0 −0.5

I compared main against fix-papilo-feastol using two complete runs of all 240 MIPLIB instances. Each main/branch instance pair ran sequentially on the same H100, using the same physical node, GPU index, 28-thread CPU mask, and 600-second time limit.

Overall performance is similar. The branch finds ~3.5 more solutions within 0.1% of the best-known objective and reduces solutions failing our postsolve feasibility check The solution is not feasible after post solve from ~2.5 to ~2.0 per run.

The +0.411 average objective gap difference is driven almost entirely by one instance, gfd-schedulen180f7d50m30k18.
Main solves this instance consistently, while the branch sometimes solves it optimally and sometimes finds no incumbent.

I couldn't reproduce #1502 and LP should simply use PSLP presolve.

Signed-off-by: Hugo Linsenmaier <hlinsenmaier@gmail.com>
@hlinsen
hlinsen requested a review from a team as a code owner August 6, 2026 19:59
@hlinsen
hlinsen requested review from Kh4ster and aliceb-nv August 6, 2026 19:59
@copy-pr-bot

copy-pr-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ddcaac19-c786-4bf0-85b1-47eb7ba450e9

📥 Commits

Reviewing files that changed from the base of the PR and between 5002b48 and 1e5f376.

📒 Files selected for processing (2)
  • cpp/src/math_optimization/solver_settings.cu
  • cpp/src/mip_heuristics/presolve/third_party_presolve.cpp
🚧 Files skipped from review as they are similar to previous changes (2)
  • cpp/src/mip_heuristics/presolve/third_party_presolve.cpp
  • cpp/src/math_optimization/solver_settings.cu

📝 Walkthrough

Walkthrough

The PR updates the default MIP absolute and relative tolerances. Papilo presolve now uses the caller-provided absolute tolerance for feasibility checks.

Changes

MIP tolerance updates

Layer / File(s) Summary
Tolerance configuration and presolve
cpp/src/math_optimization/solver_settings.cu, cpp/src/mip_heuristics/presolve/third_party_presolve.cpp
The default MIP absolute tolerance changes to 1e-6. The relative tolerance changes to 1e-12. Papilo feasibility tolerance uses the absolute_tolerance argument.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • NVIDIA/cuopt#1656: This PR also modifies Papilo presolve configuration in third_party_presolve.cpp.

Suggested reviewers: aliceb-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: Papilo now uses the configured feasibility tolerance.
Description check ✅ Passed The description explains the tolerance change and provides relevant performance comparison results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hlinsen

hlinsen commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test c6ef256

@hlinsen hlinsen added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

CI Test Summary

⏭️ All 5 test job(s) skipped.

@hlinsen

hlinsen commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 1e5f376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants