[BUG] Fix variable fixing for initial solutions - #1580
Merged
Conversation
…variables. added a guard to check if the variables are fixed to infinite or NaN bounds. Signed-off-by: Nicolas L. Guidotti <nguidotti@nvidia.com>
📝 WalkthroughWalkthroughMIP heuristic solution assignments are now seeded before completion LP processing, and fixed-variable assignments are checked for finite values before constraint updates. ChangesMIP assignment handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
akifcorduk
reviewed
Jul 16, 2026
…e fixing, take the one that is feasible. Otherwise, keep the original one. Signed-off-by: Nicolas L. Guidotti <nguidotti@nvidia.com>
CI Test Summary✅ All 31 test job(s) passed. |
akifcorduk
approved these changes
Jul 16, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When feeding initial solutions to the population, the diversity manager was fixing the variables on a default constructed problem. If the problem has free variables, it means that it was fixed to an infinity bound.
Checklist