test routing null matrix validation - #1220
Conversation
Signed-off-by: Aycsi <207523432+aycsi@users.noreply.github.com>
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
7 similar comments
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
/ok to test 6d5b75a |
|
/ok to test 575b1cc |
CI Test Summary✅ All 22 test job(s) passed. (1 skipped) |
|
/okay to test 89f131a |
📝 WalkthroughWalkthroughChangesRouting input validation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/cuopt/cuopt/tests/routing/test_warnings_exceptions.py`:
- Around line 87-90: Update the test to instantiate DataModel before the
pytest.raises block, then wrap only dm.add_cost_matrix(cost_matrix) and assert
pytest.raises(ValueError, match="^cost matrix cannot have NULL values$"). Remove
the broad Exception capture and redundant string assertion while preserving the
existing validation scenario.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 43a07905-24a7-41d6-a3e3-73bc757f306b
📒 Files selected for processing (1)
python/cuopt/cuopt/tests/routing/test_warnings_exceptions.py
tmckayus
left a comment
There was a problem hiding this comment.
lgtm assuming tests pass
|
/merge |
Description
DataModel.add_cost_matrix routes through validate_matrix, which is expected to reject matrices containing NULL values before solve-time logic. This change adds a focused negative test to lock down that contract and prevent silent regressions during future validation.
Summary