Skip to content

Remove stale single-GPU test xfails - #8450

Open
csadorf wants to merge 4 commits into
NVIDIA:mainfrom
csadorf:issue-7734-audit-test-suite-for-xpass-tests
Open

Remove stale single-GPU test xfails#8450
csadorf wants to merge 4 commits into
NVIDIA:mainfrom
csadorf:issue-7734-audit-test-suite-for-xpass-tests

Conversation

@csadorf

@csadorf csadorf commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Removes 30 stale xfail markers identified across recent CI jobs and focused GB10 stress testing.

Closes #7734

@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 4, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Aug 4, 2026
@csadorf

This comment has been minimized.

@csadorf
csadorf force-pushed the issue-7734-audit-test-suite-for-xpass-tests branch from 0233c56 to 9d35431 Compare August 5, 2026 14:43
@csadorf

This comment has been minimized.

@csadorf
csadorf force-pushed the issue-7734-audit-test-suite-for-xpass-tests branch from 9d35431 to 4bb489d Compare August 5, 2026 18:19
@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@csadorf

This comment has been minimized.

@csadorf

csadorf commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test c9c647b

@csadorf

csadorf commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 8dce4fe

@csadorf
csadorf force-pushed the issue-7734-audit-test-suite-for-xpass-tests branch from 8dce4fe to 8ad8e2c Compare August 12, 2026 17:31
@csadorf
csadorf marked this pull request as ready for review August 13, 2026 17:45
@csadorf
csadorf requested a review from a team as a code owner August 13, 2026 17:45
@csadorf
csadorf requested a review from betatim August 13, 2026 17:45
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ab6ca973-785b-48a2-a2a7-c6454d83b8d0

📥 Commits

Reviewing files that changed from the base of the PR and between 729c432 and 8ad8e2c.

📒 Files selected for processing (4)
  • python/cuml/tests/test_metrics.py
  • python/cuml/tests/test_spectral_clustering.py
  • python/cuml/tests/test_tsne.py
  • python/cuml/tests/test_umap.py
💤 Files with no reviewable changes (2)
  • python/cuml/tests/test_tsne.py
  • python/cuml/tests/test_metrics.py

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Removed expected-failure designations from metrics, spectral clustering, t-SNE, and UMAP tests.
    • These test scenarios now run as standard validations.
  • Documentation
    • Updated copyright attribution in the spectral clustering test.

Walkthrough

The change removes expected-failure markers from four cuML tests. It also updates the SPDX copyright holder in the spectral clustering test file.

Changes

Expected-failure test audit

Layer / File(s) Summary
Enable audited tests
python/cuml/tests/test_metrics.py, python/cuml/tests/test_spectral_clustering.py, python/cuml/tests/test_tsne.py, python/cuml/tests/test_umap.py
Four tests now run without xfail markers. The spectral clustering SPDX notice now includes NVIDIA CORPORATION & AFFILIATES.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to 8ad8e

This change only removes stale test exemptions and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: jcrist

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The SPDX copyright holder update in test_spectral_clustering.py is unrelated to the linked XPASS audit objective [#7734]. Move the SPDX copyright update to a separate pull request or document why it is required for this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing stale single-GPU test xfail markers.
Description check ✅ Passed The description directly relates the changes to removing stale xfail markers and auditing XPASS tests.
Linked Issues check ✅ Passed The changes remove expected-failure markers from tests covered by the XPASS audit objective in issue [#7734].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Audit test suite for XPASS tests

3 participants