Forward-merge release/26.08 into main - #8427
Merged
Merged
Conversation
Should address #8398. (could not reproduce the hangs yet though) The multi-GPU logistic regression path passed original labels directly to the QN solver, which expects class indices from 0 to n_classes - 1. Labels such as [10, 50, 20] therefore produced an invalid optimization state. This may be the cause behind observed distributed training to hang. This PR: - Encodes labels using the globally sorted classes before training. - Preserves the original values in `classes_` and predictions. - Updates `test_n_classes_small` to verify predictions, not only class discovery. - Avoid empty sparse partitions in Dask logistic regression tests. Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #8422
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.08 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.