Avoid NVSHMEM device header parsing in non-RDC CUDA translation units.#149
Merged
Conversation
Signed-off-by: Josh Romero <joshr@nvidia.com>
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent versions of NVSHMEM (3.6+, included in NVHPC 26.5) break cuDecomp builds due to changes in device API handing in
nvshmem.hwhen included in a file not compiled with RDC. This updates the non-RDCcudecomp_kernels.cupath to include NVSHMEM in host-library-only mode. Newer NVSHMEM headers no longer provide the non-RDC fallback device state declarations that older NVSHMEM releases did, so parsing the full device API from a non-RDC translation unit triggers a cascade of compile errors.The fix adds a cuDecomp-local
CUDECOMP_NVSHMEM_HOST_ONLYmacro around thecudecomp_kernels.cuhinclude incudecomp_kernels.cu. When active,cudecomp_kernels.cuhtemporarily definesNVSHMEM_HOSTLIB_ONLYwhile including NVSHMEM and related cuDecomp headers, and skips the NVSHMEM device kernel templates. The RDC translation unit remains unchanged and still sees the full NVSHMEM device API.