extend 64bit indexing for other multi tensor ops#2014
Open
POI-WX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During llm training, we encountered a case where the number of tensor elements exceeded INT_MAX, leading to illegal memory access. The multi_tensor_l2norm and multi_tensor_scale interfaces do not support int64_t indexing, while the multi_tensor_adam interface has supported int64_t indexing in previous #1765 and #1825 .
To avoid similar issues in the future, we extend the int64_t indexing to all other remaining multi tensor ops and add corresponding tests.
test.log