-
Notifications
You must be signed in to change notification settings - Fork 93
feat(recipes): gpuStack profile for the OKE family #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
atif1996
wants to merge
1
commit into
main
Choose a base branch
from
feat/oke-gpustack-profile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| # OKE GPU Setup | ||
|
|
||
| ## GPU Stack Ownership | ||
|
|
||
| OKE installs NVIDIA's device plugin automatically on every cluster, and | ||
| Oracle's GPU node images preinstall the NVIDIA driver, container toolkit, and | ||
| host MOFED. Which of those a GPU node pool actually has depends on how it was | ||
| provisioned, and the AICR recipe must match it — the `gpuStack` configuration | ||
| profile on the OKE family names the three qualified combinations: | ||
|
|
||
| | Value | Driver / toolkit | `nvidia.com/gpu` advertiser | Pool shape | | ||
| |---|---|---|---| | ||
| | `oci-default` (default) | Oracle GPU node image | OKE's auto-installed device plugin | stock OKE with Oracle GPU images | | ||
| | `operator-plugin` | Oracle GPU node image | GPU Operator's device plugin | OKE plugin disabled (node label or add-on removed) | | ||
| | `operator-managed` | GPU Operator installs both | GPU Operator's device plugin | bring-your-own driverless image | | ||
|
|
||
| MOFED is host-supplied in every value — Oracle's GPU images and the common | ||
| bring-your-own images alike carry it, so `network-operator` never deploys | ||
| `ofedDriver` on OKE, and the device plugin runs with `MOFED_ENABLED=false` | ||
| (without it, k8s-device-plugin >= 0.19.0 with CDI floods every host RDMA | ||
| uverb into every GPU pod and breaks NCCL). | ||
|
|
||
| Select the mode at recipe generation; the paths it owns are locked at every | ||
| output boundary: | ||
|
|
||
| ```shell | ||
| # Stock OKE cluster (the default) — no flag needed | ||
| aicr recipe --service oke --accelerator l40s --os ol --intent training -o recipe.yaml | ||
|
|
||
| # OKE plugin disabled, image-supplied driver | ||
| aicr recipe --service oke --accelerator l40s --os ol --intent training \ | ||
| --profile gpuStack=operator-plugin -o recipe.yaml | ||
|
|
||
| # Bring-your-own driverless image (e.g. a custom Ubuntu image) | ||
| aicr recipe --service oke --accelerator gb200 --os ubuntu --intent training \ | ||
| --profile gpuStack=operator-managed -o recipe.yaml | ||
| ``` | ||
|
|
||
| ## Default: Stock OKE (`oci-default`) | ||
|
|
||
| A default-provisioned OKE cluster with Oracle GPU images needs zero setup: | ||
| the image supplies the driver and toolkit, and OKE's device plugin advertises | ||
| `nvidia.com/gpu`. The GPU Operator manages the rest of the stack with its own | ||
| plugin disabled — running both plugins double-advertises the same GPUs, which | ||
| the #1327 exactly-one-advertiser policy forbids. | ||
|
|
||
| ## Alternative: Let the GPU Operator's Plugin Advertise (`operator-plugin`) | ||
|
|
||
| If you prefer the GPU Operator's device plugin (feature discovery, MIG, CDI | ||
| control), disable OKE's plugin on the GPU pools and select the value: | ||
|
|
||
| - **Per node pool (recommended, snapshot-visible):** add the node label | ||
| `oci.oraclecloud.com/disable-gpu-device-plugin=true` to the pool's initial | ||
| node labels at creation. | ||
| - **Per cluster:** remove the `NvidiaGpuPlugin` cluster add-on | ||
| (Terraform `addons = { NvidiaGpuPlugin = { remove = true } }`, or the | ||
| add-on lifecycle API). Note this leaves no on-node marker. | ||
|
|
||
| The driver still comes from the Oracle image — the GPU Operator installs | ||
| nothing under this value. | ||
|
|
||
| ## Alternative: Bring-Your-Own Image (`operator-managed`) | ||
|
|
||
| Custom images (OKE Ubuntu pools are always custom images) may ship no NVIDIA | ||
| stack at all. Under `operator-managed` the GPU Operator installs the driver | ||
| and toolkit, its device plugin advertises, and the DRA kubelet plugin reads | ||
| the driver userspace from the operator install path | ||
| (`/run/nvidia/driver` — the profile moves `nvidiaDriverRoot` in lockstep; | ||
| see the driver-ownership coherence rules). Disable OKE's device plugin on | ||
| these pools exactly as under `operator-plugin`. | ||
|
|
||
| If your custom image DOES bake a driver (Oracle publishes downloadable | ||
| Ubuntu GPU images with driver + CUDA + DOCA-OFED), use `operator-plugin` | ||
| instead — a second, operator-installed driver on top of an image driver is | ||
| an unqualified hybrid. | ||
|
|
||
| ## Validation | ||
|
|
||
| Qualification is partial, by design (tracked in | ||
| [#2363](https://github.com/NVIDIA/aicr/issues/2363)): | ||
|
|
||
| | Axis | Signal | Status | | ||
| |---|---|---| | ||
| | Driver (image vs operator) | `GPU.hardware.driver-loaded` on the sampled GPU node | **Qualified.** `oci-default` and `operator-plugin` require it `true` at generation — durable, since the image driver persists and the `aicr validate` pre-flight re-evaluates the same constraint. A driverless (bring-your-own image) cluster fails both with remediation steering to `operator-managed`. `operator-managed` carries the post-deployment form as a readiness-scoped **deployment-outcome check**: it verifies the operator's driver install executed; it does not prove the value was the right choice. | | ||
| | Advertiser (OKE plugin vs operator plugin) | undecided | **Deferred.** Candidate signals — the `oci.oraclecloud.com/disable-gpu-device-plugin` node label vs a cluster add-on projection — are unresolved, and the node-label constraint evaluator's universe is GKE-only today. `oci-default` vs `operator-plugin` is currently an explicit `--profile` choice; verify the plugin state on your pools yourself (`kubectl get ds -n kube-system | grep nvidia-gpu-device-plugin`). | | ||
|
|
||
| The snapshot samples a single GPU node; mixed pools are out of scope. | ||
|
|
||
| ## Oracle Add-on Interactions | ||
|
|
||
| Do **not** enable Oracle's `NvidiaGpuOperator` or `NvidiaNetworkOperator` | ||
| managed add-ons alongside AICR bundles — the bundle deploys both operators | ||
| itself, and two lifecycle managers fight over the same releases. The only | ||
| Oracle GPU add-on compatible with AICR bundles is the device plugin | ||
| (`NvidiaGpuPlugin`), and only under `oci-default`. | ||
|
|
||
| ## References | ||
|
|
||
| - [OKE: Running GPU Workloads](https://docs.oracle.com/en-us/iaas/Content/ContEng/Tasks/contengrunninggpunodes.htm) | ||
| - [OKE cluster add-ons](https://docs.oracle.com/en-us/iaas/Content/ContEng/Tasks/contengintroducingclusteraddons.htm) | ||
| - [oci-hpc-oke quickstart](https://github.com/oracle-quickstart/oci-hpc-oke) — worker images, RDMA manifests | ||
| - [AKS GPU Setup](aks-gpu-setup.md), [GKE GPU Setup](gke-gpu-setup.md) — the sibling `gpuStack` families | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Escape the pipe in the validation command.
The
| grep ...sequence is parsed as a fourth table cell. The validation table has three columns, so the row can render incorrectly. Escape the pipe as\|or move the command outside the table.Proposed fix
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 85-85: Table column count
Expected: 3; Actual: 4; Too many cells, extra data will be missing
(MD056, table-column-count)
🤖 Prompt for AI Agents
Source: Linters/SAST tools