Skip to content

[None][chore] Update API update missed in Dynamo test#16512

Merged
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/new-dynamo-api
Jul 16, 2026
Merged

[None][chore] Update API update missed in Dynamo test#16512
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/new-dynamo-api

Conversation

@brb-nv

@brb-nv brb-nv commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Description

An API update has been missed in #15918. This MR adds that.

Test Coverage

$ pytest tests/unittest/dynamo/test_imports.py

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Tests
    • Updated import validation to include the BaseLlmArgs export from the LLM arguments module.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@brb-nv
brb-nv requested a review from a team as a code owner July 16, 2026 20:17
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 540b072e-b0b2-4c7c-b5f3-86f74e673ae7

📥 Commits

Reviewing files that changed from the base of the PR and between a2595c0 and 6b1478d.

📒 Files selected for processing (1)
  • tests/unittest/dynamo/test_imports.py

📝 Walkthrough

Walkthrough

The Dynamo import acceptance list now verifies that BaseLlmArgs is available from tensorrt_llm.llmapi.llm_args.

Changes

Dynamo import validation

Layer / File(s) Summary
Extend import acceptance list
tests/unittest/dynamo/test_imports.py
Adds BaseLlmArgs to the required imports checked by the parameterized test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wanli-jiang

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Matches the required [None][chore] template and clearly references the Dynamo test import/API update.
Description check ✅ Passed Includes Description, Test Coverage, and PR Checklist sections, and the content is relevant and sufficiently filled out.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brb-nv

brb-nv commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59786 [ run ] triggered by Bot. Commit: 6b1478d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59786 [ run ] completed with state FAILURE. Commit: 6b1478d

Link to invocation

@brb-nv
brb-nv enabled auto-merge (squash) July 16, 2026 21:48
@brb-nv

brb-nv commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59787 [ run ] triggered by Bot. Commit: 6b1478d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59787 [ run ] completed with state SUCCESS. Commit: 6b1478d
/LLM/main/L0_MergeRequest_PR pipeline #48208 completed with status: 'SUCCESS'

CI Report

Link to invocation

@brb-nv
brb-nv merged commit d7cefb6 into NVIDIA:main Jul 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants