Repository navigation
test(testkit): name unsupported gateway auth modes in the error - #5248
Merged
Merged
Conversation
Co-authored-by: Evan Lezar <elezar@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com>
4 of 6 tasks
4 tasks
matthewgrossman
approved these changes
Nov 4, 2026
matthewgrossman
left a comment
matthewgrossman
left a comment
Member
There was a problem hiding this comment.
LGTM. This is the same test as in #5138, and Branch Checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a unit test that
Gateway::registerednames the gateway and the auth mode when it rejects an unsupported one (for example OIDC). Split out of #5138, where the test was outside that PR's scope.Related Issue
None. This is a small test-only change from an author with write access.
Changes
unsupported_auth_modes_are_namedtotests/testkit/testkit/src/gateway.rs. It checks the error readsgateway edge uses oidc auth.Testing
--all-targets -D warnings) are clean for the testkit workspace.cargo testintests/testkitpasses (12 tests intestkit, 1 intestkit-macros), including the new test.Checklist