Skip to content

fix(compute): preserve protobuf configuration integers - #5117

Open
shiju-nv wants to merge 1 commit into
NVIDIA:mainfrom
shiju-nv:fix/5106-protobuf-config-integers/shiju-nv
Open

shiju-nv wants to merge 1 commit into
NVIDIA:mainfrom
shiju-nv:fix/5106-protobuf-config-integers/shiju-nv

Conversation

@shiju-nv

@shiju-nv shiju-nv commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

An integer driver setting such as Kubernetes tolerationSeconds can become a fractional JSON number during protobuf decoding and fail typed configuration parsing. This preserves whole-number values through the shared converter and the actual Kubernetes rendering path.

Related Issue

Closes #5106. Part of #5114.

Changes

  • Use one fallible protobuf-to-JSON converter in all five first-party compute driver factories.
  • Preserve fractional values without rounding and reject non-finite protobuf numbers.
  • Add an integer toleration to the existing Kubernetes scheduling regression.

Release Notes

Per-sandbox integer driver settings retain their JSON number type. The separate gateway TOML PID-limit path is unchanged.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@shiju-nv shiju-nv added the test:e2e Requires end-to-end coverage label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Label test:e2e applied for 50d3a86. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@shiju-nv
shiju-nv force-pushed the fix/5106-protobuf-config-integers/shiju-nv branch from 50d3a86 to c80a053 Compare November 2, 2026 14:46
An integer driver setting such as Kubernetes `tolerationSeconds` can become a fractional JSON number during protobuf decoding and fail typed configuration parsing. This preserves whole-number values through the shared converter and the actual Kubernetes rendering path.

Signed-off-by: Shiju <shiju@nvidia.com>
@shiju-nv
shiju-nv force-pushed the fix/5106-protobuf-config-integers/shiju-nv branch from f9245d5 to de0645c Compare November 3, 2026 11:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve integer driver settings when converting protobuf configuration

2 participants