Repository navigation
Conversation
|
Label |
shiju-nv
force-pushed
the
fix/5106-protobuf-config-integers/shiju-nv
branch
from
November 2, 2026 14:46
50d3a86 to
c80a053
Compare
TaylorMutch
reviewed
Nov 3, 2026
An integer driver setting such as Kubernetes `tolerationSeconds` can become a fractional JSON number during protobuf decoding and fail typed configuration parsing. This preserves whole-number values through the shared converter and the actual Kubernetes rendering path. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
fix/5106-protobuf-config-integers/shiju-nv
branch
from
November 3, 2026 11:46
f9245d5 to
de0645c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An integer driver setting such as Kubernetes
tolerationSecondscan become a fractional JSON number during protobuf decoding and fail typed configuration parsing. This preserves whole-number values through the shared converter and the actual Kubernetes rendering path.Related Issue
Closes #5106. Part of #5114.
Changes
Release Notes
Per-sandbox integer driver settings retain their JSON number type. The separate gateway TOML PID-limit path is unchanged.
Testing
Checklist