Repository navigation
Conversation
|
Label |
shiju-nv
force-pushed
the
fix/5112-forward-target-preflight/shiju-nv
branch
from
November 2, 2026 14:46
439c081 to
2725f40
Compare
An invalid TCP relay target can reach the gateway or open a local listener before failing. This rejects it in the CLI and TypeScript SDK first, then preserves the normalized target through the handle and relay request. The gateway continues to validate every target. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
fix/5112-forward-target-preflight/shiju-nv
branch
from
November 3, 2026 11:47
2725f40 to
84eafe7
Compare
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. typescript-sdk — No explicit risk acceptance foundSandboxClient.forward previously returned the supplied ForwardHandle.targetHost unchanged but now replaces localhost with 127.0.0.1 and expanded IPv6 loopback with ::1.
Review details
Advisory review; publication gates are unchanged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An invalid TCP relay target can reach the gateway or open a local listener before failing. This rejects it in the CLI and TypeScript SDK first, then preserves the normalized target through the handle and relay request. The gateway continues to validate every target.
Related Issue
Closes #5112. Part of #5114.
Changes
Release Notes
Invalid TCP targets fail immediately with a configuration error. SSH relay targets keep their existing path.
Testing
Checklist