Repository navigation
fix(gateway): accept the full reconnect log buffer - #5049
Conversation
Signed-off-by: divesh <dgude@nvidia.com>
Signed-off-by: divesh <dgude@nvidia.com>
|
/ok to test 6f24a29 |
|
I did some looking into this with an agent, and I'm not sure this is the right solution. The cleaner fix is on the supervisor side. On reconnect, run_push_loop sends the whole backoff buffer (up to MAX_BUFFERED = 200 lines) as a single PushSandboxLogsRequest, which skips the 50-line batching the normal send loop uses. If the supervisor splits that flush into the same 50-line chunks, it stays within the gateway's existing 100-line limit, and this has several advantages:
Separately, the gateway's .take(N) drops extra lines with no warning, which is why this went unnoticed. A warn! when a batch is cut short would make any future mismatch visible. |
Signed-off-by: divesh <dgude@nvidia.com>
|
#5049 (comment) |
|
/ok to test d41c49b |
Summary
Raise the gateway's per-message log ingestion cap from 100 to 200, matching the supervisor's existing reconnect buffer. A full retained backlog can now arrive in its existing single replay message, without silently truncating half the lines.
Related Issue
No linked issue, found while testing, easy to replicate
Changes
Release Notes
Testing
Local macOS tests used the installed Homebrew Z3 library via LIBRARY_PATH=/opt/homebrew/opt/z3/lib.
The repository-wide pre-commit hook was bypassed following its unrelated concurrent Python environment cleanup failure; the scoped Rust checks above passed.
Checklist