Repository navigation
fix(deps): resolve RustSec advisories and restore cargo-deny - #5030
Merged
Merged
Conversation
Signed-off-by: Adrien Langou <alangou@nvidia.com>
|
Label |
Contributor
Author
|
/ok to test 8144168 |
SDAChess
previously approved these changes
Oct 29, 2026
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Contributor
Author
|
/ok to test 9dcf456 |
alangou
enabled auto-merge
October 29, 2026 15:44
SDAChess
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update vulnerable Rust dependencies and replace the unmaintained
rustls-pemfileparser. This fixes thepulldown-cmarkfailure incargo deny checkand removes seven of the eight advisory exceptions fromdeny.toml.Related Issue
No separate issue: dependency/build fix for
cargo deny checkfailing onRUSTSEC-2026-0414.Changes
pulldown-cmarkto 0.13.5,anyhowto 1.0.104, andcrossbeam-epochto 0.9.21.zstdrequirement to0.14, withCargo.lockresolvingzstd0.14.3 andzstd-safe8.2.0. This removes the older vulnerable versions and resolves three ignored advisories.crypto-bigint0.5.5 and unused legacy RustCrypto dependencies.rustls-pemfilewith Rustls' native PEM API across the workspace, examples, and tests. Keep rejection of non-certificate blocks in strict CA bundle readers.The only remaining exception is
RUSTSEC-2023-0071(RSA Marvin):russh/ssh-keyand RSA test fixtures still require affected versions, and RustSec lists no patched release. Update its explanation to reflect the actual dependency paths.Release Notes
Testing
cargo deny --locked check: passes advisories, licenses, bans, and sources; existing duplicate-version warnings remain.0.14, locked metadata resolution and the full cargo-deny check still pass with an unchangedCargo.lock.-D warningspasses for all root workspace targets, the V8 example, all default E2E targets, and the modified service test withe2e-dockerenabled.check-cargo-lockfiles.sh; the lockfile alignment check passes.openshell-core,openshell-sandbox-backend,openshell-sandbox,openshell-supervisor-network,openshell-cli, andopenshell-driver-vm(9 pre-existing skipped tests). Run with/usr/sbininPATHandTMPDIR=/var/tmpfor the local ext4 tools and Git-discovery fixtures.service_bearer_passthroughE2E passes using freshly built sandbox/supervisor images and gateway/CLI binaries from this branch.The broader E2E
--all-targets --features e2e-dockerlint check reports existing errors in untouchededge_tunnel_e2e.rs,policy_activation.rs, andwebsocket_conformance.rs(naming/docs, duration units, casts/formatting, and a mutex guard held across awaits). Those unrelated files are outside this dependency fix.Checklist