Repository navigation
fix(network): align destination checks for direct connections - #5004
Merged
johntmyers merged 2 commits intoOct 28, 2026
Merged
Conversation
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
|
Label |
alangou
previously approved these changes
Oct 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. policy — No explicit risk acceptance foundHostless allowed_ips rules previously authorized mapped hostname connections, but transparent TCP now requires the caller to match a hosted endpoint in the DNS record.
Review details
Advisory review; publication gates are unchanged. |
johntmyers
enabled auto-merge
October 28, 2026 18:16
purp
approved these changes
Oct 28, 2026
johntmyers
deleted the
fix/direct-connection-destination-checks/johntmyers
branch
October 28, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep policy DNS address selection consistent with endpoint decisions for direct connections. Apply destination checks to selected address candidates before constructing upstream connectors.
Changes
Testing
Prior local validation:
Pending:
Checklist