Repository navigation
fix(supervisor): guard shared supervisor pool configuration - #4988
Merged
drew merged 3 commits intoOct 28, 2026
Merged
Conversation
Raise the gateway's minimum supervisor pool recovery timeout from 10 to 30 seconds. A failed pool member takes up to about 24 seconds to detect, so a shorter deadline ended workloads another member would have adopted. The Sandbox Protocol range stays 10 to 300 seconds for compatibility. Refuse an [openshell.gateway.supervisor_pool] table during config preflight, and at startup before the compute driver is built, unless the selected driver hosts sandboxes on the shared supervisor pool. A new ComputeDriverFactory::uses_shared_supervision hook reports this; the Kubernetes factory returns true with supervisor_topology = "gateway". Widen the readiness deadline of a shared-startup supervisor test that timed out under full-workspace load. Signed-off-by: divesh <dgude@nvidia.com>
drew
reviewed
Oct 28, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
approved these changes
Oct 28, 2026
drew
enabled auto-merge
October 28, 2026 03:52
Collaborator
Author
|
/ok to test 24648e9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes found while testing #4864: reject a pool recovery timeout shorter than member failure detection, reject a
supervisor_pooltable no driver uses in preflight and before driver startup, and deflake a supervisor startup test.Related Issue
No issue. Observed while testing #4864:
config preflightaccepted[openshell.gateway.supervisor_pool]withoutsupervisor_topology = "gateway". Startup rejected it only after building the driver.shared_startup_uses_selected_backend_through_readiness_and_shutdownhit its 10 s readiness deadline under full-workspace load.Changes
recovery_timeout_secs/supervisor.recoveryTimeoutSecondsfrom 30 to 300 (was 10 to 300). The Sandbox Protocol range stays 10 to 300. A test pins the minimum above worst-case detection.ComputeDriverFactory::uses_shared_supervision(defaultfalse; Kubernetes returnstruefor the gateway topology). Preflight for the selected driver and startup beforebuildreject an unused pool table with the existing messages.debug-openshell-clusterskill.Testing
cargo clippy -p openshell-supervisor-control -p openshell-server -p openshell-gateway -p openshell-supervisor --all-targets -- -D warningscargo nextest runon the same crates: 2816 passedhelm unittest deploy/helm/openshell: 424 passedopenshell-gateway config preflighton Helm-rendered configs: shared topology passes; a pool table without it and a 20 s timeout fail; startup fails before building the driverChecklist