Repository navigation
fix(python): ship credential driver protocol bindings - #4760
Merged
TaylorMutch merged 2 commits intoOct 20, 2026
Merged
Conversation
Closes #4759 Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-4760.docs.buildwithfern.com/openshell |
|
Label |
TaylorMutch
approved these changes
Oct 20, 2026
TaylorMutch
left a comment
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed locally at 3d1a5ed. No actionable findings. All 22 focused Python tests passed, and the built wheel passed verification. PR checks passed.
TaylorMutch
deleted the
fix/4759-python-credential-driver-bindings/maxdubrinsky
branch
October 20, 2026 23:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start building and shipping the
credential_driverandextensionprotos in the Python SDK.Related Issue
Closes #4759
Changes
credential_driver.protoandextension.protonow generating python files (excluded here)LINE_REWRITESconstant with something built onPROTO_FILES, can revert if we want to maintain this by hand stillTesting
Checklist