feat(gpu): route device selection through driver config#1716
Draft
elezar wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-1716.docs.buildwithfern.com/openshell |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
69be336 to
e106f02
Compare
3 tasks
009a6ee to
4c18100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft POC for routing driver-specific GPU device selection through the selected runtime
driver_configwhile keeping portable GPU presence/count inresource_requirements.gpu. This targets the updated PR #1156 shape and keeps Kubernetes out of exact device-id support for now.Related Issue
Related to #1156 and #1589.
Changes
gpu_device_idshandling for Docker, Podman, and VM driver config.--gpu-deviceto imply GPU intent and set the portable GPU count to match the requested device IDs.gpu_device_idsat the driver level: non-empty IDs require a non-zero GPU count, duplicates are rejected, and the number of unique IDs must equalresource_requirements.gpu.count.Testing
mise run pre-commitpassesmise exec -- cargo test -p openshell-core -p openshell-driver-docker -p openshell-driver-podman -p openshell-driver-vm --lib gpumise run checkChecklist