fix(cli): respect gateway name for mTLS lookup#1626
Merged
Conversation
c398750 to
9b077ff
Compare
Collaborator
|
/ok to test 9b077ff |
Collaborator
|
@alexclewontin this looks good, if you can rebase on main and fix the conflict I'll gladly merge |
9b077ff to
09b76b4
Compare
Contributor
Author
|
@maxamillion thanks, rebased & conflicts fixed |
Signed-off-by: Alex Lewontin <alex.lewontin@canonical.com>
09b76b4 to
9d56ba5
Compare
maxamillion
approved these changes
Jun 4, 2026
Collaborator
|
/ok to test 9d56ba5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CLI mTLS certificate discovery so an explicit gateway name is honored for loopback HTTPS endpoints. This unblocks the Kubernetes setup flow where the Helm-generated client bundle is installed under
gateways/k8s/mtlsand the gateway is registered as--name k8s, as suggested here: https://docs.nvidia.com/openshell/kubernetes/setup.Inferring
openshellas the default gateway name when no--nameis provided still occurs (crates/openshell-cli/src/run.rs:911-927)Related Issue
None.
Changes
--name k8susesgateways/k8s/mtls--nameon loopback derives and usesgateways/openshell/mtls--name k8sdoes not fall back togateways/openshell/mtlsTesting
cargo run -p openshell-cli -- gateway add https://127.0.0.1:8080 --local --name k8scargo run -p openshell-cli -- statuscargo test -p openshell-cli --test mtls_integration gateway_add_mtls_loopbackpassescargo test -p openshell-cli --test mtls_integrationpassescargo test -p openshell-cli mtls_certs_exist_for_gateway_uses_explicit_name_for_loopback_endpointpassesmise run pre-commitpassesChecklist