Skip to content

refactor(openshell): remove temp SSH config helper - #6806

Merged
apurvvkumaria merged 9 commits into
refactor/openshell-exec-process-recovery/aefrom
refactor/openshell-remove-temp-ssh-config/ae
Jul 17, 2026
Merged

apurvvkumaria merged 9 commits into
refactor/openshell-exec-process-recovery/aefrom
refactor/openshell-remove-temp-ssh-config/ae

Conversation

@ericksoa

@ericksoa ericksoa commented Jul 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Deletes the temporary SSH-config helper after the migration leaves it with no production callers.

This is PR 13 of 21 in the OpenShell gRPC migration stack.

Changes

  • Remove the unused helper and its unit tests.
  • Retain the repository scanner rule that rejects future reintroduction.
  • Add no replacement code.

Stack

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Existing tests cover changed behavior — justification: this PR deletes code with no remaining production caller; typecheck and repository inventory checks protect the boundary.
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs not applicable — justification: this slice changes only internal transport implementation or tests.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: transport-boundary self-review completed; mutations select one transport before dispatch and are never replayed automatically.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — typecheck, repository checks, build, docs, and exact-head hooks passed
  • Applicable broad gate passed — targeted and changed-graph tests were used; CI will run the repository-required broad gates
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only) — not applicable
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9b6082ee-b683-4bd6-8821-c7c89f55335e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/openshell-remove-temp-ssh-config/ae

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the refactor/openshell-e... branch.

TypeScript / code-coverage/cli

The overall coverage in the refactor/openshell-r... branch remains at 79%, unchanged from the refactor/openshell-e... branch.

Show a code coverage summary of the most impacted files.
File refactor/openshell-e... 8599fc7 refactor/openshell-r... 40bb55a +/-
src/lib/onboard...tup-nim-vllm.ts 89% 71% -18%
src/lib/state/o...config-merge.ts 96% 90% -6%
src/lib/onboard.ts 30% 29% -1%
src/lib/diagnostics/debug.ts 14% 29% +15%
src/lib/adapter...dbox-control.ts 0% 76% +76%
src/lib/adapter...teway-config.ts 0% 77% +77%
src/lib/state/s...tore-payload.ts 0% 83% +83%
src/lib/adapter...dbox-control.ts 0% 94% +94%
src/lib/adapter...trol-routing.ts 0% 94% +94%
src/lib/adapter...ndbox-upload.ts 0% 99% +99%

Updated July 15, 2026 03:22 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

github-actions Bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 2 warnings · 0 suggestions
  • Model comparison: normalized findings differ; normalized E2E selections match; Nemotron reported the same number of blockers, 2 more warnings, the same number of suggestions.

Nemotron output stays in workflow artifacts and does not change the assessment above.

Since last review: 0 prior items resolved · 0 still apply · 0 new items found

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

ericksoa added 2 commits July 13, 2026 16:20
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
@wscurran wscurran added area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery refactor PR restructures code without intended behavior change labels Jul 14, 2026
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

@apurvvkumaria apurvvkumaria left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head review complete for 40bb55a7d1196293d11011fa0243d6d5451d2b59 against stacked base 6cf6e3e87f2e430ab23228b457395919cc93020e.

The slice only deletes the temporary SSH-config helper and its self-test. On this exact stacked base there are no remaining production or test callers, no runtime cleanup behavior is lost, and the repository transport scanner still rejects recognizable reintroduction. All commits are GitHub Verified, DCO and CI are green, protected E2E passed, and there are no unresolved threads or actionable advisor findings.

Approved for the declared stack order. #6805 must land first; do not retarget or cherry-pick this deletion directly onto current main, where callers still exist.

@wscurran wscurran added v0.0.88 and removed v0.0.86 labels Jul 17, 2026
@apurvvkumaria
apurvvkumaria merged commit 195d004 into refactor/openshell-exec-process-recovery/ae Jul 17, 2026
50 checks passed
@apurvvkumaria
apurvvkumaria deleted the refactor/openshell-remove-temp-ssh-config/ae branch July 17, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery refactor PR restructures code without intended behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants