Repository navigation
refactor(openshell): remove temp SSH config helper - #6806
apurvvkumaria merged 9 commits into
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. Since last review: 0 prior items resolved · 0 still apply · 0 new items found E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
apurvvkumaria
left a comment
There was a problem hiding this comment.
Exact-head review complete for 40bb55a7d1196293d11011fa0243d6d5451d2b59 against stacked base 6cf6e3e87f2e430ab23228b457395919cc93020e.
The slice only deletes the temporary SSH-config helper and its self-test. On this exact stacked base there are no remaining production or test callers, no runtime cleanup behavior is lost, and the repository transport scanner still rejects recognizable reintroduction. All commits are GitHub Verified, DCO and CI are green, protected E2E passed, and there are no unresolved threads or actionable advisor findings.
Approved for the declared stack order. #6805 must land first; do not retarget or cherry-pick this deletion directly onto current main, where callers still exist.
195d004
into
refactor/openshell-exec-process-recovery/ae
Summary
Deletes the temporary SSH-config helper after the migration leaves it with no production callers.
This is PR 13 of 21 in the OpenShell gRPC migration stack.
Changes
Stack
refactor/openshell-exec-process-recovery/aeto see only this slice.Type of Change
Quality Gates
Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm run docsbuilds without warnings (doc changes only) — not applicableSigned-off-by: Aaron Erickson aerickson@nvidia.com