Forward-merge release/0.8 into main - #894
Merged
Merged
Conversation
#### Overview Expose OTLP trace and log batch-queue drops through direct subscriber runtime diagnostics after a successful force flush, while retaining final shutdown accounting. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Record only newly observed queue-drop deltas after successful trace and log force flushes, keeping diagnostic counts cumulative through shutdown. - Preserve direct flush behavior and plugin-only teardown errors. - Add Rust and Python regressions and update Rust, Python, Node.js, Go, and OTLP documentation. #### Where should the reviewer start? Start with `DiagnosticBatchSpanProcessor` and `DiagnosticBatchLogProcessor`, which now advance the reported cumulative drop total after a successful flush. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: none ## Summary by CodeRabbit - **New Features** - Added an API for retrieving runtime diagnostics as JSON. - Successful `force_flush()` calls now update diagnostics with observed dropped spans and log events. - **Bug Fixes** - Drop counts are reported cumulatively across repeated flushes and shutdown. - Concurrent queue drops are tracked accurately without duplicate or missed reporting. - Diagnostics continue to include the affected collector endpoint. - **Documentation** - Clarified runtime diagnostic behavior across supported language APIs. - **Tests** - Added coverage for cumulative reporting, queue overflow, flushing, shutdown, and endpoint details. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Maryam Najafian (https://github.com/mnajafian-nv) URL: #891
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.8 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.