Skip to content

chore - Add small set of GitHub checks and copilot rules - #691

Merged
ArangoGutierrez merged 1 commit into
NVIDIA:device-apifrom
ArangoGutierrez:copilot_rules
Jan 14, 2026
Merged

ArangoGutierrez merged 1 commit into
NVIDIA:device-apifrom
ArangoGutierrez:copilot_rules

Conversation

@ArangoGutierrez

Copy link
Copy Markdown
Contributor

Summary

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📚 Documentation
  • 🔧 Refactoring
  • 🔨 Build/CI

Component(s) Affected

  • Core Services
  • Documentation/CI
  • Fault Management
  • Health Monitors
  • Janitor
  • Other: ____________

Testing

  • Tests pass locally
  • Manual testing completed
  • No breaking changes (or documented)

Checklist

  • Self-review completed
  • Documentation updated (if needed)
  • Ready for review

@ArangoGutierrez ArangoGutierrez self-assigned this Jan 14, 2026
@ArangoGutierrez ArangoGutierrez added the device-api issue/PR against Devic-api branch label Jan 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds GitHub checks and Copilot rules for improved code quality and consistency across the NVSentinel project. It introduces automated linting via GitHub Actions and establishes internal coding guidelines to be enforced by Copilot during code reviews.

Changes:

  • Added GitHub workflow for automated linting on pull requests
  • Configured Copilot with custom coding guidelines specific to NVSentinel's architecture
  • Fixed a protobuf generation issue in the api module's Makefile

@ArangoGutierrez
ArangoGutierrez changed the base branch from main to device-api January 14, 2026 15:18
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez
ArangoGutierrez merged commit 7fc1f70 into NVIDIA:device-api Jan 14, 2026
2 checks passed
ArangoGutierrez added a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

device-api issue/PR against Devic-api branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants