Skip to content

[26.04_linux-nvidia-bos] net: mana: Add support for PF device 0x00C1#467

Closed
ltrager wants to merge 1 commit into
NVIDIA:26.04_linux-nvidia-bosfrom
ltrager:mana_pf_c1
Closed

[26.04_linux-nvidia-bos] net: mana: Add support for PF device 0x00C1#467
ltrager wants to merge 1 commit into
NVIDIA:26.04_linux-nvidia-bosfrom
ltrager:mana_pf_c1

Conversation

@ltrager

@ltrager ltrager commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@nirmoy nirmoy added the help wanted Extra attention is needed label Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Validation Report

Patchscan ✅ No Missing Fixes

All cherry-picked commits checked — no missing upstream fixes found.

PR Lint ❌ Errors found

Details 
Checking 1 commits...

Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local        │ Referenced upstream / Patch subject                              │ Patch-ID   │ Subject │ SoB chain                 │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ 49a7e67e9939 │ [SAUCE] net: mana: add support for pf device 0x00c1              │ N/A        │ N/A     │ haiyangz, kuba, ltrager   │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘

Lint results:
E: 49a7e67e9939 ("net: mana: Add support for PF device 0x00C1"): not SAUCE/UBUNTU/Revert but has no upstream reference trailer (cherry picked from commit ... or backported from ...)

@nvmochs

nvmochs commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

@ltrager Couple of comments...

  • What is the patch needed for? I don't see it in the distro SS - is that intentional?
  • The pick SHA is from linux-next, let's either wait for Linus to pull into his branch or indicate this is from linux-next by adding "linux-next" after the pick SHA.
  • One non-blocking comment from Codex review: in mana_gd_init_registers(), the backport uses return mana_gd_init_pf_regs(pdev); even though this branch’s helper returns void.
    • Maybe the backport should just call mana_gd_init_pf_regs() at this callsite rather than using 'return' ?

@haiyangz @ltrager
net: mana: Add support for PF device 0x00C1
49a7e67 
Update the device id table to include the new device id 0x00C1.
This device's BAR layout is similar to VF's, update the function,
mana_gd_init_registers(), accordingly.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Link: https://patch.msgid.link/20260605212302.2135499-1-haiyangz@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(backported from commit 53a65db linux-next)
[ltrager: minor merge conflicts]
Signed-off-by: Lee Trager <ltrager@nvidia.com>
@ltrager

ltrager commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

@nvmochs - Thanks for the review

  • What is the patch needed for? I don't see it in the distro SS - is that intentional?

Brad asked me to backport this

  • The pick SHA is from linux-next, let's either wait for Linus to pull into his branch or indicate this is from linux-next by adding "linux-next" after the pick SHA.

Added linux-next

  • One non-blocking comment from Codex review: in mana_gd_init_registers(), the backport uses return mana_gd_init_pf_regs(pdev); even though this branch’s helper returns void.

    • Maybe the backport should just call mana_gd_init_pf_regs() at this callsite rather than using 'return' ?

Updated as suggested. It looks like the driver was updated to include better error handling which utilized returns. 7.0 doesn't have that support so just dropped the return.

@nvidia-bfigg

nvidia-bfigg commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

This is a request from MSFT Azure team for their VR bringup. I should have given Lee more information. This is a requirement for their work.

@nvmochs

nvmochs commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks Lee and Brad for clarifying.

No further issues from me.

Acked-by: Matthew R. Ochs <mochs@nvidia.com>

@jamieNguyenNVIDIA

jamieNguyenNVIDIA commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Is this also needed for 26.04_linux-nvidia (i.e. would this device be used on Grace systems)?

Acked-by: Jamie Nguyen <jamien@nvidia.com>

@nirmoy

nirmoy commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

BaseOS Kernel Review

Summary

No issues found across the reviewed commits.

Findings: no problems found

Latest watcher review: open review

Kernel deb build: successful (download debs, 4 files)

Head: 49a7e67e9939

This comment is maintained by nv-pr-bot. It is updated when the GitHub watcher publishes a newer review.

@nirmoy nirmoy added has_2_acks and removed help wanted Extra attention is needed has_1_ack labels Jun 16, 2026
clsotog
clsotog approved these changes Jun 16, 2026
View reviewed changes

@clsotog clsotog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Carol L Soto <csoto@nvidia.com>

@clsotog

clsotog commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

They will go directly to bos kernel? Many CSP still in 6.17 kernel for Vera.

@nvidia-bfigg

nvidia-bfigg commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

They will go directly to bos kernel? Many CSP still in 6.17 kernel for Vera.

Yes, they are doing their factory bringup using the 0.5 and 0.6 releases we have sent out. 0.6 is the latest and they require this change. It's late, they only told me about it yesterday.

@clsotog

clsotog commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

They will go directly to bos kernel? Many CSP still in 6.17 kernel for Vera.

Yes, they are doing their factory bringup using the 0.5 and 0.6 releases we have sent out. 0.6 is the latest and they require this change. It's late, they only told me about it yesterday.

We switch to resolute in 0.6 build 2 not sure if that is out. Before that is noble.

@nvmochs

nvmochs commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Merged, closing PR.

cc1482331083 (nresolute/nvidia-bos-next) net: mana: Add support for PF device 0x00C1

@nvmochs nvmochs closed this Jun 16, 2026
@ltrager ltrager mentioned this pull request Jun 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clsotog clsotog clsotog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has_2_acks pending_review_comment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ltrager @nvmochs @nvidia-bfigg @jamieNguyenNVIDIA @nirmoy @clsotog @haiyangz