feat(libsy): add routed client callbacks - #26
Conversation
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
|
@sir-merge-a-lot groom |
Previous updates (collapsed)🤖 sir-merge-a-lot Resolving conflicts🔄 sir-merge-a-lot is resolving conflicts on this MR. Detected 2 conflicting file(s) (LOW). I'll update this comment with the result. This can take a couple of minutes. 🤖 sir-merge-a-lot Merge analysisStrategy: cherry_pick_with_resolution Commits:
Conflicts:
Resolution ladder trace
Final failure reason: Why now: I analyzed 2 conflict(s) on 📖 The resolution ladder · How strategy is selected 🤖 sir-merge-a-lot Resolving conflicts🔄 sir-merge-a-lot is resolving conflicts on this MR. Detected 5 conflicting file(s) (REGENERATE). I'll update this comment with the result. This can take a couple of minutes. 🤖 sir-merge-a-lot Could not auto-resolve⏱️ sir-merge-a-lot could not auto-resolve this MR in time. I stopped after ~3 minute(s) because the automated resolution path was too slow or unavailable on this conflict, so I will not be resolving this MR automatically. It needs manual conflict resolution. Resolved 4 of 5 file(s) before stopping. Re-invoke 🤖 sir-merge-a-lot Resolving conflicts🔄 sir-merge-a-lot is resolving conflicts on this MR. Detected 5 conflicting file(s) (REGENERATE). I'll update this comment with the result. This can take a couple of minutes. 🤖 sir-merge-a-lot Could not auto-resolve⏱️ sir-merge-a-lot could not auto-resolve this MR in time. I stopped after ~3 minute(s) because the automated resolution path was too slow or unavailable on this conflict, so I will not be resolving this MR automatically. It needs manual conflict resolution. Resolved 4 of 5 file(s) before stopping. Re-invoke 🤖 sir-merge-a-lot Resolving conflicts🔄 sir-merge-a-lot is resolving conflicts on this MR. Detected 5 conflicting file(s) (REGENERATE). I'll update this comment with the result. This can take a couple of minutes. 🤖 sir-merge-a-lot Could not auto-resolve⏱️ sir-merge-a-lot could not auto-resolve this MR in time. I stopped after ~3 minute(s) because the automated resolution path was too slow or unavailable on this conflict, so I will not be resolving this MR automatically. It needs manual conflict resolution. Resolved 4 of 5 file(s) before stopping. Re-invoke 🤖 sir-merge-a-lot Resolving conflicts🔄 sir-merge-a-lot is resolving conflicts on this MR. Detected 5 conflicting file(s) (REGENERATE). I'll update this comment with the result. This can take a couple of minutes. 🤖 sir-merge-a-lot Could not auto-resolve⏱️ sir-merge-a-lot could not auto-resolve this MR in time. I stopped after ~3 minute(s) because the automated resolution path was too slow or unavailable on this conflict, so I will not be resolving this MR automatically. It needs manual conflict resolution. Resolved 4 of 5 file(s) before stopping. Re-invoke |
81c5d5c to
9261a09
Compare
fcdc0ad to
eab29f6
Compare
|
@sir-merge-a-lot groom |
1 similar comment
|
@sir-merge-a-lot groom |
|
@sir-merge-a-lot groom |
1 similar comment
|
@sir-merge-a-lot groom |
Summary
RouterCallback<D>hooks to the libsy routed-client loop.RoutedClientBuilder::callback(...)so clients register callbacks once, independent of the selected algorithm.Validation
cargo test -p libsycargo fmt --all --checkcargo clippy -p libsy --all-targets -- -D warningsgit diff --check -- crates/libsy/src/client.rs crates/libsy/src/lib.rs