Skip to content

fix(ci): drop vedas pin — package deleted from PyPI, breaks every sandbox image build#1509

Merged
gwarmstrong merged 1 commit into
mainfrom
fix/drop-deleted-vedas-pin
Jul 14, 2026
Merged

fix(ci): drop vedas pin — package deleted from PyPI, breaks every sandbox image build#1509
gwarmstrong merged 1 commit into
mainfrom
fix/drop-deleted-vedas-pin

Conversation

@nicgupta-nvidia

@nicgupta-nvidia nicgupta-nvidia commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

What / Why

vedas==0.0.1 has been deleted from PyPI (both https://pypi.org/pypi/vedas/json and https://pypi.org/simple/vedas/ return 404). The sandbox image build (Dockerfile.sandbox:82, uv pip install -r requirements/sandbox.lock) therefore fails with:

× No solution found when resolving dependencies:
╰─▶ Because vedas was not found in the package registry and you require vedas==0.0.1,
    we can conclude that your requirements are unsatisfiable.

This reds the CPU tests workflow on every PR/branch right now (first seen on run 29051295001 — the failure is in Build Images, before any test runs, and the failing lock line is identical on main).

Fix

Remove the entry: nothing in the repo imports vedas (zero import vedas / from vedas hits); it was an unpinned line in requirements/stem.txt swept into sandbox.lock. 3 deleted lines total.

Impact

Unblocks CI repo-wide, including the in-review #1479 and #1507.

Summary by CodeRabbit

  • Chores
    • Removed the unused vedas package from the application’s dependency list.

…ndbox image build

vedas==0.0.1 has been removed from PyPI entirely (both /pypi/vedas/json
and /simple/vedas/ return 404), so the sandbox image build fails at
'uv pip install -r requirements/sandbox.lock' with 'vedas was not found
in the package registry' -- which currently reds the CPU-tests workflow
on every PR and branch (first seen on run 29051295001).

Nothing in the repo imports vedas (zero 'import vedas'/'from vedas'
hits); it was an unpinned entry in requirements/stem.txt swept into the
lock. Remove it from stem.txt and the corresponding two lock lines.

Signed-off-by: Nick Gupta <nicgupta@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f1d82383-03b7-4c84-962d-44459ff7c28b

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3fb04 and 0ef14b1.

⛔ Files ignored due to path filters (1)
  • requirements/sandbox.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • requirements/stem.txt
💤 Files with no reviewable changes (1)
  • requirements/stem.txt

📝 Walkthrough

Walkthrough

Removes vedas from the stem requirements list, leaving utils followed by wbdata.

Changes

Dependency list cleanup

Layer / File(s) Summary
Remove vedas requirement
requirements/stem.txt
Deletes vedas from the dependency list.
Estimated code review effort: 1 (Trivial) ~2 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes removing the vedas pin to fix CI/build failures caused by the package being removed from PyPI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/drop-deleted-vedas-pin

Comment @coderabbitai help to get the list of available commands.

@nicgupta-nvidia nicgupta-nvidia self-assigned this Jul 13, 2026
@gwarmstrong
gwarmstrong merged commit 74b8649 into main Jul 14, 2026
5 checks passed
@gwarmstrong
gwarmstrong deleted the fix/drop-deleted-vedas-pin branch July 14, 2026 16:23
nicgupta-nvidia added a commit that referenced this pull request Jul 14, 2026
Bring in #1509 (drop deleted vedas pin) so the sandbox image build — and
therefore this PR's CI — is unblocked.

Signed-off-by: Nick Gupta <nicgupta@nvidia.com>
nicgupta-nvidia added a commit that referenced this pull request Jul 14, 2026
Bring in #1509 (drop deleted vedas pin) so the sandbox image build and
CPU-tests CI are unblocked; keeps the branch current with main.

Signed-off-by: Nick Gupta <nicgupta@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants