Skip to content

fix: correct evaluation and logging output#673

Draft
binaryaaron wants to merge 2 commits into
mainfrom
binaryaaron/log-fixes
Draft

fix: correct evaluation and logging output#673
binaryaaron wants to merge 2 commits into
mainfrom
binaryaaron/log-fixes

Conversation

@binaryaaron

@binaryaaron binaryaaron commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep JSONL events canonical while rendering Rich tables only on the plain console
  • report exact membership-inference attack counts and percentages without Plotly renormalization
  • correct PII progress timing and step labels, fraction formatting, and user-facing log severities
  • store final evaluation, generation, timing, failure, and vLLM completion values in W&B summary while retaining Hugging Face training curves in history
  • add the evaluation scorecard panel and an explicitly opted-in HTML/report artifact; report upload is best-effort, retry-safe, and may disclose distribution labels

Test plan

  • mise run check
  • mise run typecheck
  • focused Engineer Arc suite: 196 passed
  • W&B/results/CLI/vLLM focused suite: 145 passed
  • genuine offline W&B smoke: no scalar history keys; media history limited to evaluation/scorecard and opted-in evaluation/report
  • mixed console/JSONL and reset-timing regressions: 2 passed
  • systemic, style/type-safety, and general council reviews accepted the final product patch

Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5ba51ed4-52e7-43b2-b0e0-94d08d5fe5ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch binaryaaron/log-fixes

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant