fix(runspec): reject unsupported executors in nemo-run pipeline launcher#300
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix(runspec): reject unsupported executors in nemo-run pipeline launcher#300andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
PipelineConfig.executor accepts 'local' | 'slurm' | 'dgxcloud' | 'lepton', but run_nemo_run dispatched every non-'local' value into the Slurm branch, silently building a SlurmExecutor for 'dgxcloud'/'lepton' (or failing with a misleading '--account required for Slurm executor'). Make the slurm branch explicit and error out clearly on unsupported executors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PipelineConfig.executoris declared asLiteral["local", "slurm", "dgxcloud", "lepton"], butrun_nemo_runonly special-cases"local":Every other value — including
"dgxcloud"and"lepton"— falls into theelsebranch, so a user passingexecutor="dgxcloud"gets either a misleading--account required for Slurm executorerror or, worse, a Slurm job silently submitted to the wrong backend.Fix
Make the Slurm branch explicit (
elif config.executor == "slurm") and reject anything else with a clear error:Testing
dgxcloud/leptonnow return rc=1 with the clear error;slurmwithout--accountstill hits its proper validationpytest tests/nemo_runspec— 186 passed, 3 pre-existing failures onmain(unrelated data_mover/lepton tests, fail identically without this change)