fix(kit): resolve version aliases to ints in Artifact.from_uri#299
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix(kit): resolve version aliases to ints in Artifact.from_uri#299andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
Artifact.from_uri('art://name:prod') stored the alias string 'prod' in
artifact._version (typed int | None), so artifact.uri emitted the
corrupted 'art://name:vprod' instead of round-tripping to the resolved
version. Resolve alias strings through the registry entry's alias table,
falling back to the latest version when the alias is unknown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Artifact.from_uri("art://name:prod")(alias version) stored the alias string inartifact._version, which is typedint | None. Theuri/art_pathproperties then emit a corrupted URI:Fix
In
from_uri, only assign_versiondirectly when the parsed version is anint; resolve alias strings through the registry entry's alias table, falling back to the latest version.All URI forms now round-trip correctly:
Testing
prod-> v1)pytest tests/kit— 90 passed