fix(steps): point translate/nemo_curator docs reference at existing page#298
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix(steps): point translate/nemo_curator docs reference at existing page#298andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
The step.toml [reference] docs field pointed at docs/customize/steps/translate/nemo-curator.md, which does not exist, failing tests/steps/test_manifests.py::test_reference_paths_point_to_real_files. Point it at docs/translation/getting-started.md, the tutorial for this exact step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/nemotron/steps/translate/nemo_curator/step.tomldeclares:docs/customize/does not exist in the repo, so the manifest validation test fails onmain:This is the only
docs/customizereference in anystep.toml.Fix
Point
docsatdocs/translation/getting-started.md— the existing tutorial that walks through running this exact step (nemotron steps run translate/nemo_curator).Testing
pytest tests/steps/test_manifests.py— 6 passed (previously 1 failed)