Repository navigation
test: simplify test setup and strengthen assertions - #2537
Open
joaovv-Vitor wants to merge 14 commits into
Open
joaovv-Vitor wants to merge 14 commits into
joaovv-Vitor wants to merge 14 commits into
Conversation
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 991f934. Codex assisted with adaptation, implementation, and validation. Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 9cf2e4a, 81263cd, 96013d2. Codex assisted with adaptation, implementation, and validation. Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 330097f, 89214de, 8ee7a6a, 6d4741d, 088d217, a2121b7, a90a557, 7dfbb38. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 2b59c67. Codex assisted with adaptation, implementation, and validation. Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: df14b83. Codex assisted with adaptation, implementation, and validation. Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: c2c4065, 0e9b833, 1707914, 44fbf3a. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 102596e, 6dfe48f, c8b6ce1, 3fa9c6a. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 926b286, 5063181. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 2dabd22. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 0e6c88e, 1f60a9a. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: b2b5fa7. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 95fd210. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 2c217fb. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
A focused follow-up to NVIDIA-NeMo#2518 after NVIDIA-NeMo#2530, adapted from the team branch. Source commits: 2dc3908. Codex assisted with adaptation, implementation, and validation. Co-authored-by: Maria Letícia Dantas <mleticiadantas@alu.ufc.br> Signed-off-by: joaovv_vitor <jrodriguescontatato@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up on the test-maintenance proposal after the LFU timing changes were
merged in #2530. This PR contains the remaining changes from the team's
experimental branch in 14 self-contained commits, with each commit addressing
one issue or a category of related issues.
evaluation CLI arguments, Clavata payloads, Patronus chat configuration,
and manifest action modules.
serialization surfaces and LLMRails registration methods into focused cases.
The test observes the second caller entering the loading sentinel's wait
path before releasing the first loader, checks that only one pipeline is
constructed, and propagates worker failures through futures.
Changes are limited to 11 test files. The LFU clock and concurrent-clear tests
accepted in #2530 are preserved, along with newer upstream tests. Production
code, dependencies, lockfiles, and generated changelogs are unchanged.
Related Issue(s)
Related to #2518 and follows #2530.
Commit organization follows @Pouyanpi's
request for a single PR with self-contained commits.
Issue assignee: @joaovv-Vitor.
Verification
repository pre-commit checks before proceeding to the next commit.
whitespace, license checks, and ty. Hooks without applicable files were skipped.
(Verified), with DCO sign-offs.
methods merged in test: make LFU cache tests deterministic #2530 and the newer generation and LLMRails tests.
AI Assistance
The changes were adapted from João Vitor and Maria Letícia Dantas's team
branch, with source-commit references and human coauthor credit preserved
where applicable. Codex assisted with separating the changes, adapting them
to current develop, strengthening HF loading synchronization, validation,
and drafting this description.
Checklist