Repository navigation
Conversation
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
[Low impact] The PR appears safe to merge, with the previous privacy issue fixed and no new actionable issues found. SummaryReworks the GitHub overview around agent workflows.
The previous privacy-guidance finding is fully addressed. No new actionable issues were found. Reviews (2) · Last reviewed commit: "docs: ground overview claims in implemen..." · Reviewed by Greptile |
| Third-party endpoints have separate terms and privacy practices. The NVIDIA NeMo Guardrails library can use inference endpoints such as NVIDIA Build (`build.nvidia.com`). If you use NVIDIA Build or another third-party endpoint, that endpoint's terms of service and privacy practices apply independently of the library. Any telemetry opt-out in the NVIDIA NeMo Guardrails library does not extend to the endpoint you choose. NVIDIA Build is intended for evaluation and testing only and must not be used in production environments. Do not submit confidential information or personal data when using NVIDIA Build. | ||
|
|
||
| ## Inviting the community to contribute | ||
| Refer to [telemetry and privacy](https://docs.nvidia.com/nemo/guardrails/latest/resources/telemetry) for the full schema, local audit file, opt-out options, and third-party endpoint terms. |
There was a problem hiding this comment.
Promised privacy guidance is missing
The linked page only covers library telemetry; it does not contain the promised third-party endpoint terms. This PR also removes the README's explanation that third-party services have separate privacy terms and that the library's opt-out does not cover them. Readers following this link cannot find that guidance. Move it into the linked page or link to a page that contains it.
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 253
Comment:
**Promised privacy guidance is missing**
The linked page only covers library telemetry; it does not contain the promised third-party endpoint terms. This PR also removes the README's explanation that third-party services have separate privacy terms and that the library's opt-out does not cover them. Readers following this link cannot find that guidance. Move it into the linked page or link to a page that contains it.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Project framing and release updates README.md, .github/workflows/release.yml |
The README introduces configurable checks for agent workflows and updates project links. The release workflow stops editing the README and removes the related pull request text and path entry. |
Check workflow and quickstart README.md |
The README explains check verdicts and tool execution boundaries, then adds a refund-tool example using a CEL rule, check_async(), and IORails. |
Deployment and check coverage README.md |
The README describes the HTTP proxy, coding-agent hooks, framework integration, check coverage, and supported engines. |
Telemetry and project policies README.md |
The README shortens its telemetry description and updates contribution, license, and citation links. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested labels: documentation
Suggested reviewers: pouyanpi
Merge Risk: 
Minimal · up to bec71
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
5
-
Full details: Test Results For Major Changes
-
Explanation
The PR makes a substantial README and release-workflow documentation change. Its description includes testing information: a network-disabled quickstart run, seven policy and schema boundary checks, target and URL validation, pre-commit, diff, and documentation checks. No numeric, convergence, or performance change is introduced.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Description
Update the GitHub README around agent workflows, using Monika's product proposal and a technical introduction. Add a runnable, model-free refund-policy quickstart, four integration use cases, and a linked list of NeMo Guardrails capabilities. Describe the current coverage and limitations of the SDK, API server, hooks server, and experimental proxy.
Remove the hard-coded README release notice and the release workflow step that updated it. Apply the NVIDIA documentation style guide. Keep the release announcement in release-notes tracking and focus the README on NeMo Guardrails capabilities.
Preview: https://github.com/NVIDIA-NeMo/Guardrails/blob/miyoungc/ngr-1020-guardrails-github-overview-update/README.md
Related Issue(s)
The tracking issue is in Linear; there is no linked triaged GitHub issue.
Verification
RunnableRailsworks without changing the default framework.uv run --locked pre-commit run --files README.md .github/workflows/release.ymlandgit diff --checkpassed.make docs-fernpassed with 0 errors and 567 warnings.Source references for the factual audit
These checks establish implemented behavior; they do not establish detector effectiveness or qualify every remote service.
AI Assistance
Codex helped prepare the README and perform local verification. Human review is pending.
Checklist
Summary by CodeRabbit