Repository navigation
fix(checks): Log transformed messages on OTEL request span - #2440
tgasser-nv wants to merge 9 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughIORails now preserves rail rewrites in request content capture, including rewrites made before a rail blocks. Rail results carry the rewritten text, and documentation and tests describe and check capture behavior across checks, generation, and streaming. ChangesRewritten content capture
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change is mergeable after normal checks; no actionable issue remains in the supplied evidence. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
Full details: Test Results For Major ChangesExplanation This PR makes a cross-cutting change to request-span content capture across check, generation, and streaming paths. It also changes how rail rewrites are preserved before a block. These privacy-sensitive behavior changes are not minor. The PR description’s Verification section contains only the template prompt. Its commit subjects mention tests expected to fail, but do not report final test execution or results.
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
5ddcc9c to
e946b68
Compare
|
Staged Fern docs preview: https://nvidia-preview-pr-2440.docs.buildwithfern.com/nemo/guardrails |
|
…ecked response unmasked Signed-off-by: tgasser-nv <200644301+tgasser-nv@users.noreply.github.com>
e946b68 to
d50b073
Compare
Description
Prior to this PR, in
check_async()andcheck()both wrote out the original un-transformed messages prior to any transformation. This could leak the sensitive data transform rails like Gliner-PII should protect.Related Issue(s)
Verification
Pre-commit
Unit-test
AI Assistance
Checklist