feat: replace MeaningUnitAspect enum with open-ended str

[asteier2026]

Summary

• Drops the MeaningUnitAspect enum from EntityDispositionSchema and schemas/__init__.py
• Changes MeaningUnitSchema.aspect from MeaningUnitAspect to str
• Updates tests to use string literals instead of enum values

Motivation

The enum was causing record loss: the model returns open-ended aspect values like "goal", "symptom", "diagnosis" that can't be exhaustively enumerated. Validation errors were silently dropping records.

[greptile-apps]

Greptile Summary

This PR removes the MeaningUnitAspect enum and replaces MeaningUnitSchema.aspect with an open-ended str field, fixing silent record loss caused by validation rejecting LLM-returned values like "goal", "symptom", and "diagnosis" that the enum couldn't represent.

• rewrite.py: Deletes the 16-value MeaningUnitAspect enum; MeaningUnitSchema.aspect becomes str = Field(min_length=1), and the same min_length guard is added to QualityQAItemSchema.aspect (which previously had none).
• schemas/__init__.py: Removes MeaningUnitAspect from the re-export list, keeping the public API consistent.
• test_qa_generation.py: Swaps enum references for equivalent plain string literals; no logic changes.

Confidence Score: 5/5

Safe to merge — the change is narrowly scoped, removes a closed enum that was causing record loss, and replaces it with a validated open-ended string.

All three changed files are consistent: the enum is fully deleted, the public re-export list is updated, tests use plain string equivalents, and both aspect fields now carry a min_length=1 guard. No remaining references to MeaningUnitAspect exist anywhere in the repo.

No files require special attention.

Important Files Changed

Filename	Overview
src/anonymizer/engine/schemas/rewrite.py	Removes MeaningUnitAspect enum; changes MeaningUnitSchema.aspect to str = Field(min_length=1) and adds the same guard to QualityQAItemSchema.aspect. Clean and correct.
src/anonymizer/engine/schemas/init.py	Removes MeaningUnitAspect from the import list and __all__, consistent with its deletion from rewrite.py.
tests/engine/test_qa_generation.py	Replaces MeaningUnitAspect.ROLE / MeaningUnitAspect.ENVIRONMENT with plain string literals, keeping tests aligned with the new schema.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[LLM returns meaning unit\ne.g. aspect = 'goal'] --> B{Validate aspect}
    
    subgraph Before
        B1["MeaningUnitAspect enum\n(16 fixed values)"] --> C1{aspect in enum?}
        C1 -- No --> D1["ValidationError\n→ record silently dropped"]
        C1 -- Yes --> E1[Record accepted]
    end

    subgraph After
        B2["str = Field(min_length=1)"] --> C2{aspect non-empty?}
        C2 -- No --> D2["ValidationError\n(empty string rejected)"]
        C2 -- Yes --> E2[Record accepted]
    end

    B --> B1
    B --> B2

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[LLM returns meaning unit\ne.g. aspect = 'goal'] --> B{Validate aspect}
    
    subgraph Before
        B1["MeaningUnitAspect enum\n(16 fixed values)"] --> C1{aspect in enum?}
        C1 -- No --> D1["ValidationError\n→ record silently dropped"]
        C1 -- Yes --> E1[Record accepted]
    end

    subgraph After
        B2["str = Field(min_length=1)"] --> C2{aspect non-empty?}
        C2 -- No --> D2["ValidationError\n(empty string rejected)"]
        C2 -- Yes --> E2[Record accepted]
    end

    B --> B1
    B --> B2

Loading

_{Reviews (3): Last reviewed commit: "fix: add min_length=1 to MeaningUnitSche..." | Re-trigger Greptile}