Finalize frontend PR: Replace hard-coded URLs with environment variables and add CI checks#57
Merged
csecrestjr merged 1 commit intoAug 31, 2025
Conversation
csecrestjr
marked this pull request as ready for review
August 31, 2025 17:18
Copilot
AI
changed the title
[WIP] Frontend: finalize API client PR — remove WIP and add CI check for hard-coded backend URLs
Finalize frontend PR: Replace hard-coded URLs with environment variables and add CI checks
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finalizes the frontend configuration by removing hard-coded backend URLs and implementing a CI workflow to prevent their reintroduction.
Problem
The frontend contained multiple hard-coded
http://localhost:5000URLs, creating deployment issues and violating best practices:Solution
Frontend Configuration Updates
frontend/chat-ui/src/api.js: Centralized API configuration with environment variable supportfrontend/chat-ui/.env.example: Template for environment variables setupfrontend/chat-ui/vite.config.js: Added proxy configuration for seamless developmentfrontend/user_login.js: Replaced all hard-coded URLs with environment variables:frontend/federationStatusCLI.js: Added environment variable fallback patternCI/CD Protection
.github/workflows/check-hardcoded-urls.yml: GitHub Actions workflow that fails builds if hard-coded backend URLs are detectedscripts/list-hardcoded-urls.sh: Helper script for local development testingThe CI check intelligently excludes:
Build Dependencies
Fixed missing frontend dependencies to ensure successful builds:
Usage
Development: The Vite proxy handles API calls automatically when
VITE_API_BASEis emptyProduction: Set
VITE_API_BASEenvironment variable to your backend URLLocal Testing: Run
./scripts/list-hardcoded-urls.shto check for violationsBenefits
The chat-ui components (TopBar, Sidebar, etc.) were already using relative URLs correctly and required no changes.
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.