repro: fix kafka container port handling (advertised listener + controller port) - #118
Merged
Anubhuti Sinha (anubhutisinha04) merged 2 commits intoAug 7, 2026
Conversation
The advertised listener was hardcoded to localhost:9092, so a KAFKA_PORT override let clients bootstrap on the custom port but then redirected them to 9092 for produce connections. Found running the stack on a host where 9092 was already taken.
Nothing outside the container uses 9093 (the quorum voter address is container-local), but the hardcoded host binding made 'up' fail on any host where 9093 was already taken.
Anthony Sligar (sligara7)
changed the title
Anubhuti Sinha (anubhutisinha04)
approved these changes
Aug 7, 2026
Anubhuti Sinha (anubhutisinha04)
merged commit Aug 7, 2026
fb9c81e
into
NSLS2:demo/ios-nsls2
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line fixes to the kafka container in reproduce.sh, found while running the stack on a host where the default ports were already taken. Defaults are unchanged — with no env overrides the behavior is identical to before.
localhost:${KAFKA_PORT}.-p 9093:9093published the controller port to the host, but nothing outside the container uses it (the quorum voter address is container-local). The needless binding madeupfail on any host where 9093 was taken. Removed.Field-tested: the 2026-08-07 validation run (up + smoke + a completed XAS_scan with the fluorescence detector) ran with these fixes and KAFKA_PORT=9094 on a host where 9092 hosted another broker.