Quick start for the inner-loop demo; fix its PV-write smoke test; refresh integration README - #116
Merged
Anubhuti Sinha (anubhutisinha04) merged 4 commits intoAug 7, 2026
Conversation
direct_control_service defaults to read-only, so the README's PV-write smoke test was rejected. Opt in to writes like every integration pod does.
Document all six pods (standalone, with-queueserver and profile-seeded were missing), fix the full-pod IOC count, drop the stale 'localdevs is not mounted' claim, list the newer exercisers, and trim the shipped queueserver pod out of the roadmap.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates developer-facing documentation and compose defaults to reflect the expanded integration pod set (including queueserver and standalone modes) and to make the root compose stack write-enabled for simulated IOC development.
Changes:
- Expanded
integration/README.mdto document new pod surfaces, shared assets, and exercisers (including queueserver compatibility). - Enabled
DIRECT_CONTROL_GLOBAL_READ_ONLY=falsein the rootdocker-compose.ymlfor local simulated-IOC usage. - Added a root README “Quick start” and documented the
shared-schema/write-permissions requirement.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| integration/README.md | Rewrites and expands integration environment docs to cover new pods, queueserver, and exercisers. |
| docker-compose.yml | Changes default direct-control behavior to allow writes in the local stack. |
| README.md | Adds quick start steps and documents a common failure mode (schema export directory permissions). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anubhuti Sinha (anubhutisinha04)
previously approved these changes
Aug 6, 2026
…s, note CA pinning behind write-enable
Anubhuti Sinha (anubhutisinha04)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified against a fresh checkout of main brought up with the root docker-compose stack.
Compose fix
The README's second smoke-test command (
POST /api/v1/pv/set) was rejected becausedirect_control_servicedefaults to read-only and the root compose never opted in to writes — every integration pod already setsDIRECT_CONTROL_GLOBAL_READ_ONLY: "false". The inner-loop stack now does the same (it only talks to the simulated IOC). Both smoke commands verified passing: the write returnssuccess: trueand reads back 3.14.Root README
shared-schema/must be writable by container uid 1000 — the backends export their OpenAPI schemas there at startup and exit if the write is denied.integration/README.md refresh
The file predated half of the current tree:
standalone/,with-queueserver/andprofile-seeded/were missing entirely (with-queueserver was still described as future roadmap).localdevs.pyis "not mounted into any container yet" — every compose surface mounts it.direct_control_standalone.sh,queueserver_api_compat.py,_exerciser_lib.sh) plushappi/runtime_seed.jsonandprofile_collections/test_collection/.