Eiger Ophyd Async Implementation - #9
Merged
Merged
Conversation
…ing available to fileio
Thomas Hopkins (thopkins32)
changed the title
|
Once this is working as intended, could we add it to |
…ic back for nimgs_per_file
…ured not used in ADEiger
… to 0 at the start
Thomas Hopkins (thopkins32)
requested review from
Jennefer Maldonado (jennmald),
Jakub Wlodek (jwlodek) and
Max Rakitin (mrakitin)
July 22, 2025 19:40
Jakub Wlodek (jwlodek)
left a comment
Jakub Wlodek (jwlodek)
left a comment
There was a problem hiding this comment.
Looks good! Just two minor notes.
Thomas Hopkins (thopkins32)
force-pushed
the
eiger-async
branch
from
July 22, 2025 20:47
f43b19c to
efdaff6
Compare
Contributor
Author
|
I commented out the pyright type checking for now. We have to fix errors unrelated to this PR. |
Max Rakitin (mrakitin)
requested review from
Copilot and
Anthony Sligar (sligara7)
September 4, 2025 15:07
Max Rakitin (mrakitin)
previously approved these changes
Sep 19, 2025
Max Rakitin (mrakitin)
left a comment
Max Rakitin (mrakitin)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! It's a lot of code, so I did not read every detail, but the idea looks correct. We'll test it once the detector is available.
Contributor
Author
|
Max Rakitin (@mrakitin) or Jakub Wlodek (@jwlodek) can one of you approve? It dismissed the prior approval since I had to fix a merge conflict. |
Jakub Wlodek (jwlodek)
previously approved these changes
Oct 20, 2025
Jakub Wlodek (jwlodek)
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements ADEiger using Ophyd Async.
This exposes all of the documented PVs in ADEiger and the logic for operating the detector using the
FileWriterorStreaminterface.To use the
FileWriterinterface, you must use theEigerWriterclass when initializing the detector (this is the default behavior).Also implemented is a set of unit tests that mock the actual behavior of the Eiger detector and its file writing interface.