Fixes distribution build and formatting - #41
Merged
Conversation
Dan Henriksen (dihenriksen)
changed the title
Thomas A Caswell (tacaswell)
force-pushed
the
build-package-update
branch
from
June 25, 2026 18:30
142a22c to
7d8683e
Compare
Thomas A Caswell (tacaswell)
previously approved these changes
Jun 25, 2026
We do not have a requirements.txt in this repo
These are never run and not complete, but are tripping the linters.
I advocated for these!
Thomas A Caswell (tacaswell)
force-pushed
the
build-package-update
branch
from
June 25, 2026 23:51
2392b1e to
644fda7
Compare
Thomas A Caswell (tacaswell)
approved these changes
Jun 25, 2026
Thomas A Caswell (tacaswell)
left a comment
Thomas A Caswell (tacaswell)
left a comment
Contributor
There was a problem hiding this comment.
Tested at the beamline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hynek/build-and-inspect-python-packageusing the sha:hynek/build-and-inspect-python-package@d44ca7d
The tests still fail but those are fixed in other branches.