Ophyd implemetation for Eiger Detector - #4
Merged
Merged
Conversation
Max Rakitin (mrakitin)
previously approved these changes
Jul 9, 2025
Max Rakitin (mrakitin)
left a comment
Max Rakitin (mrakitin)
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just one note is below.
Max Rakitin (mrakitin)
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is an Ophyd implementation for the Eiger Detector. It was tested on real hardware and successfully writes files and can be used within Bluesky plans.
What makes this implementation more complex than other area detector implementations is how the file writing occurs. The EPICS driver ADEiger exposes the Eiger's ability to write to a custom file format which we use here. The
EigerFileHandleris a "synthetic" AD plugin that ensures that the proper resource and datum documents are generated for these custom files. It is not an actual plugin with PVs.