Replace mypy with pyright and fix errors - #10
Merged
Conversation
Thomas Hopkins (thopkins32)
marked this pull request as ready for review
July 10, 2025 21:08
Thomas Hopkins (thopkins32)
requested review from
Jennefer Maldonado (jennmald) and
Max Rakitin (mrakitin)
July 10, 2025 21:30
Contributor
|
This looks good to me. Would we later on apply pyright to all tla-tools packages and possibly profile collections? maybe my question is really why was Mypy used in the first place? cookie template? |
Jennefer Maldonado (jennmald)
approved these changes
Jul 16, 2025
Contributor
Author
|
Yeah mypy came with the scientific-python template. I think we should probably make our own at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I personally prefer pyright over mypy. Reasoning is here: https://microsoft.github.io/pyright/#/mypy-comparison?id=differences-between-pyright-and-mypy